-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add v6 and v7 migration guides #4315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a comprehensive v7 migration guide and reorganizes the existing migration documentation structure. The migration guide documents breaking changes in Jedis 7.0.0, including removal of deprecated sharding features, base class changes, and introduction of new builder patterns.
- Removal of deprecated sharding/sharded features (JedisSharding, ShardedPipeline, etc.)
- Base class consolidation (PipelineBase → AbstractPipeline, TransactionBase → AbstractTransaction)
- Documentation restructuring with new migration guide structure
Reviewed Changes
Copilot reviewed 25 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/redis/clients/jedis/builders/UnifiedJedisConstructorReflectionTest.java | Updated test to remove reference to deprecated ShardedConnectionProvider |
| src/test/java/redis/clients/jedis/benchmark/ShardingBenchmark.java | Removed entire benchmark class for deprecated sharding functionality |
| src/test/java/redis/clients/jedis/benchmark/ShardedBenchmark.java | Removed entire benchmark class for deprecated sharded functionality |
| src/test/java/redis/clients/jedis/ShardingTest.java | Removed comprehensive test class for deprecated sharding functionality |
| src/test/java/redis/clients/jedis/ShardedPipelineTest.java | Removed test class for deprecated sharded pipeline functionality |
| src/test/java/redis/clients/jedis/ShardedConnectionTest.java | Removed test class for deprecated sharded connection functionality |
| src/main/java/redis/clients/jedis/providers/ShardedConnectionProvider.java | Removed deprecated sharded connection provider class |
| src/main/java/redis/clients/jedis/mcf/MultiDbTransaction.java | Updated to extend AbstractTransaction instead of deprecated TransactionBase |
| src/main/java/redis/clients/jedis/mcf/MultiDbPipeline.java | Updated to extend AbstractPipeline instead of deprecated PipelineBase |
| src/main/java/redis/clients/jedis/UnifiedJedis.java | Removed deprecated constructors and updated return types |
| src/main/java/redis/clients/jedis/TransactionBase.java | Removed deprecated base class |
| src/main/java/redis/clients/jedis/Transaction.java | Updated to extend AbstractTransaction instead of deprecated TransactionBase |
| src/main/java/redis/clients/jedis/ShardedPipeline.java | Removed deprecated sharded pipeline class |
| src/main/java/redis/clients/jedis/ShardedCommandObjects.java | Removed deprecated sharded command objects class |
| src/main/java/redis/clients/jedis/ShardedCommandArguments.java | Removed deprecated sharded command arguments class |
| src/main/java/redis/clients/jedis/ReliableTransaction.java | Updated to extend AbstractTransaction instead of deprecated TransactionBase |
| src/main/java/redis/clients/jedis/PipelineBase.java | Removed deprecated base class |
| src/main/java/redis/clients/jedis/Pipeline.java | Updated to extend AbstractPipeline instead of deprecated PipelineBase |
| src/main/java/redis/clients/jedis/MultiNodePipelineBase.java | Updated to extend AbstractPipeline instead of deprecated PipelineBase |
| src/main/java/redis/clients/jedis/JedisSharding.java | Removed deprecated sharding client class |
| mkdocs.yml | Reorganized migration guide structure and added new v7 migration guide |
| docs/migration-guides/v6-to-v7.md | Added comprehensive migration guide for v6 to v7 changes |
| docs/migration-guides/v3-to-v4.md | Updated cross-references to use new file paths |
| docs/failover.md | Added migration section and updated documentation for v7 changes |
| README.md | Updated version references and simplified getting started section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Bump client version - Update list of supported Redis versions - Remove references to JedisPool - Remove reference to Google Group
e2e493d to
646a37c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/migration-guides/v6-to-v7.md:1
- Extra closing parenthesis after the link.
# Jedis 7.0.0 Migration Guide
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Test Results 280 files 280 suites 11m 53s ⏱️ Results for commit d312f2b. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…im/6-to-7-migration-guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
commit 297279e Author: Igor Malinovskiy <u.glide@gmail.com> Date: Thu Oct 9 13:06:10 2025 +0200 Add v6 and v7 migration guides (#4315) * Add migration guide for v7 * Move all migration guides to subfolder * Update readme: - Bump client version - Update list of supported Redis versions - Remove references to JedisPool - Remove reference to Google Group * Remove duplicated content in the migration guide * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add missing v5 to v6 migration guide * Fix broken link * Update outdated modules section in README --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit 3645601 Author: Ivo Gaydazhiev <ivo.gaydazhiev@redis.com> Date: Thu Oct 9 13:53:02 2025 +0300 Dedicated profile for running Scenario tests (#4312) * Dedicated profile for running Scenario tests to run only scenario tests mvn -Pscenario-tests clean verify * format * remove import after rebase conflict * fix RedisRestAPIIT scenario test - increase expected bdb's count to account for additional db added to test env - fix incorrect bdbid used for lag-aware availablity checks now using bdb of'"re-active-active" * fix LagAwareStrategySslIT scenario test - Now exception is propagated in case of ssl connection errors instead of returning UNHEALTHY - updated the test to current expectations - Enhanced test to ensure untrusted default certificate * java 8 compatibility * remove @tag("integration") from IntegrationTest* to avoid multiple runs of same test --------- Co-authored-by: Igor Malinovskiy <u.glide@gmail.com> commit 07bf3b0 Author: Igor Malinovskiy <u.glide@gmail.com> Date: Thu Oct 9 12:00:36 2025 +0200 [automatic failover] Update failover docs (#4314) Update failover docs - Add migration guide from 6.x to 7.0 - Add instructions on optional deps - Clean up wording to refer to multiDbClient instead of connection provider commit 158e726 Author: Igor Malinovskiy <u.glide@gmail.com> Date: Thu Oct 9 11:14:28 2025 +0200 Remove deprecated constructors, classes and JedisSharding (#4311) * Remove JedisSharding * Remove deprecated constructors in UnifiedJedis * Clean up UnifiedJedisConstructorReflectionTest * Remove remaining ShardedCommandArguments * Remove deprecated PipelineBase * Remove deprecated TransactionBase * Remove unused attr in MultiDbTransaction commit 5db1a39 Author: Igor Malinovskiy <u.glide@gmail.com> Date: Thu Oct 9 10:04:06 2025 +0200 Remove spellcheck (#4309) Nowadays, AI reviewing tools like CoPilot catch spellcheck issues better than pyspelling without a burden of maintaining wordlist.txt
…4317) * [automatic failover] Replace EchoStrategy with PingStrategy (#4313) * - replace EchoStrategy with PingStrategy * - fix doc * [automatic failover] Remove UnifiedJedis experimental constructor accepting MultiDbConnectionProvider (#4316) * Remove UnifiedJedis(MultiDbConnectionProvider) experimental constructor The recommended way to create MultiDbClient is using MultiDbClient.builder(). Update all tests to use the builder pattern. Fixes #4307 * revert unintentional change in MultiDbClientBuilder * Squashed commit of the following: commit 297279e Author: Igor Malinovskiy <u.glide@gmail.com> Date: Thu Oct 9 13:06:10 2025 +0200 Add v6 and v7 migration guides (#4315) * Add migration guide for v7 * Move all migration guides to subfolder * Update readme: - Bump client version - Update list of supported Redis versions - Remove references to JedisPool - Remove reference to Google Group * Remove duplicated content in the migration guide * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add missing v5 to v6 migration guide * Fix broken link * Update outdated modules section in README --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> commit 3645601 Author: Ivo Gaydazhiev <ivo.gaydazhiev@redis.com> Date: Thu Oct 9 13:53:02 2025 +0300 Dedicated profile for running Scenario tests (#4312) * Dedicated profile for running Scenario tests to run only scenario tests mvn -Pscenario-tests clean verify * format * remove import after rebase conflict * fix RedisRestAPIIT scenario test - increase expected bdb's count to account for additional db added to test env - fix incorrect bdbid used for lag-aware availablity checks now using bdb of'"re-active-active" * fix LagAwareStrategySslIT scenario test - Now exception is propagated in case of ssl connection errors instead of returning UNHEALTHY - updated the test to current expectations - Enhanced test to ensure untrusted default certificate * java 8 compatibility * remove @tag("integration") from IntegrationTest* to avoid multiple runs of same test --------- Co-authored-by: Igor Malinovskiy <u.glide@gmail.com> commit 07bf3b0 Author: Igor Malinovskiy <u.glide@gmail.com> Date: Thu Oct 9 12:00:36 2025 +0200 [automatic failover] Update failover docs (#4314) Update failover docs - Add migration guide from 6.x to 7.0 - Add instructions on optional deps - Clean up wording to refer to multiDbClient instead of connection provider commit 158e726 Author: Igor Malinovskiy <u.glide@gmail.com> Date: Thu Oct 9 11:14:28 2025 +0200 Remove deprecated constructors, classes and JedisSharding (#4311) * Remove JedisSharding * Remove deprecated constructors in UnifiedJedis * Clean up UnifiedJedisConstructorReflectionTest * Remove remaining ShardedCommandArguments * Remove deprecated PipelineBase * Remove deprecated TransactionBase * Remove unused attr in MultiDbTransaction commit 5db1a39 Author: Igor Malinovskiy <u.glide@gmail.com> Date: Thu Oct 9 10:04:06 2025 +0200 Remove spellcheck (#4309) Nowadays, AI reviewing tools like CoPilot catch spellcheck issues better than pyspelling without a burden of maintaining wordlist.txt --------- Co-authored-by: Ivo Gaydazhiev <ivo.gaydazhiev@redis.com>
No description provided.