Skip to content

Commit

Permalink
Accept Double and Boolean in MapOutput #2429
Browse files Browse the repository at this point in the history
  • Loading branch information
mp911de committed Jul 6, 2023
1 parent dd0715e commit 3dbdbd9
Show file tree
Hide file tree
Showing 2 changed files with 103 additions and 0 deletions.
26 changes: 26 additions & 0 deletions src/main/java/io/lettuce/core/output/MapOutput.java
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,32 @@ public void set(long integer) {
key = null;
}

@Override
public void set(double number) {

if (key == null) {
key = (K) Double.valueOf(number);
return;
}

V value = (V) Double.valueOf(number);
output.put(key, value);
key = null;
}

@Override
public void set(boolean flag) {

if (key == null) {
key = (K) Boolean.valueOf(flag);
return;
}

V value = (V) Boolean.valueOf(flag);
output.put(key, value);
key = null;
}

@Override
public void multi(int count) {

Expand Down
77 changes: 77 additions & 0 deletions src/test/java/io/lettuce/core/output/MapOutputUnitTests.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
/*
* Copyright 2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.lettuce.core.output;

import static org.assertj.core.api.Assertions.*;

import java.nio.ByteBuffer;

import org.junit.jupiter.api.Test;

import io.lettuce.core.codec.StringCodec;

/**
* Unit tests for {@link MapOutput}.
*
* @author Mark Paluch
*/
class MapOutputUnitTests {

@Test
void shouldAcceptValue() {

MapOutput<String, String> sut = new MapOutput<>(StringCodec.UTF8);
sut.multi(2);
sut.set(ByteBuffer.wrap("hello".getBytes()));
sut.set(ByteBuffer.wrap("world".getBytes()));

assertThat(sut.get()).containsEntry("hello", "world");
}

@Test
void shouldAcceptBoolean() {

MapOutput<String, Object> sut = new MapOutput(StringCodec.UTF8);
sut.multi(2);
sut.set(ByteBuffer.wrap("hello".getBytes()));
sut.set(true);

assertThat(sut.get()).containsEntry("hello", true);
}

@Test
void shouldAcceptDouble() {

MapOutput<String, Object> sut = new MapOutput(StringCodec.UTF8);
sut.multi(2);
sut.set(ByteBuffer.wrap("hello".getBytes()));
sut.set(1.2);

assertThat(sut.get()).containsEntry("hello", 1.2);
}

@Test
void shouldAcceptInteger() {

MapOutput<String, Object> sut = new MapOutput(StringCodec.UTF8);
sut.multi(2);
sut.set(ByteBuffer.wrap("hello".getBytes()));
sut.set(1L);

assertThat(sut.get()).containsEntry("hello", 1L);
}

}

0 comments on commit 3dbdbd9

Please sign in to comment.