-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: add a cluster-capable version of flushallAsync
#1359
Labels
type: feature
A new feature
Milestone
Comments
Great proposal. Do you want to submit a pull request? |
mp911de
added
the
status: help-wanted
An issue that a contributor can help us with
label
Jul 22, 2020
Sure. I may need some help understanding some plumbing, but I'll open a draft and we can work through the specifics there. |
mp911de
pushed a commit
that referenced
this issue
Jul 29, 2020
flushallAsync gets now dispatched to all cluster nodes. Original pull request: #1360.
mp911de
pushed a commit
that referenced
this issue
Jul 29, 2020
flushallAsync gets now dispatched to all cluster nodes. Original pull request: #1360.
mp911de
added a commit
that referenced
this issue
Jul 29, 2020
mp911de
added a commit
that referenced
this issue
Jul 29, 2020
mp911de
removed
the
status: help-wanted
An issue that a contributor can help us with
label
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RedisAdvancedClusterCommands
has an implementation offlushall
that will:It does not, however, have a matching implementation of
flushallAsync
, which instead lives in the world of single-node commands. That can lead to some surprising behavior:To be fair, there is a viable workaround:
…but it's very easy to fall into the trap of thinking you've cleared your whole cluster even if only one shard was cleared. I'm writing to suggest adding a cluster-capable version of
flushallAsync()
toRedisAdvancedClusterCommands
and its async/reactive cousins.The text was updated successfully, but these errors were encountered: