Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WITHSCORE option to ZRANK and ZREVRANK commands #2450

Closed
wants to merge 1 commit into from
Closed

Add WITHSCORE option to ZRANK and ZREVRANK commands #2450

wants to merge 1 commit into from

Conversation

sokomishalov
Copy link
Collaborator

@sokomishalov sokomishalov commented Jul 17, 2023 •
edited
Loading

Resolve #2410

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@sokomishalov sokomishalov requested a review from mp911de July 17, 2023 08:55
@mp911de mp911de added the type: feature A new feature label Jul 17, 2023
@mp911de
Copy link
Collaborator

mp911de commented Jul 17, 2023

Thanks for your pull request. Instead of introducing a new type, I would suggest using ScoredValue<Long>

@sokomishalov sokomishalov force-pushed the feature/zrank-zrevrank-withscore branch from 0a16872 to 30116d3 Compare July 18, 2023 18:50
@sokomishalov
Copy link
Collaborator Author

@mp911de Sure! Although we still need to introduce a new CommandOutput implementation, otherwise breaking changes have to be done to ScoredValueOutput

mp911de pushed a commit that referenced this pull request Aug 15, 2023
@mikhael-sokolov-rs @mp911de
Add WITHSCORE option to ZRANK and ZREVRANK commands #2410
f3818bd 
Original pull request: #2450
mp911de added a commit that referenced this pull request Aug 15, 2023
@mp911de
Polishing #2410
cd703a4 
Replace additional output with ScoredValueOutput capable of parsing Long values.

Original pull request: #2450
@mp911de mp911de added this to the 6.3 milestone Aug 15, 2023
@mp911de
Copy link
Collaborator

mp911de commented Aug 15, 2023

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Aug 15, 2023
@sazzad16 sazzad16 mentioned this pull request Dec 19, 2023
Closed
@mp911de mp911de linked an issue Dec 19, 2023 that may be closed by this pull request
Add WITHSCORE option to ZRANK and ZREVRANK #2438
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.3.0.RELEASE
Development

Successfully merging this pull request may close these issues.

Add WITHSCORE option to ZRANK and ZREVRANK Add WITHSCORE option to ZRANK and ZREVRANK commands
3 participants
@sokomishalov @mp911de @mikhael-sokolov-rs