Add GEOSEARCH to read-only commands #2568 #2569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set GEOSEARCH as read-only command to allow running the command on replicas.
mp911de
added
status: help-wanted
|
@mp911de @dengliming Can this PR be merged? I want to add another PR just like this to support FCALL_RO but since the unit test for this counts number of commands in the read only list, I want to open my PR after this is merged to main. |
|
@mp911de Is this ready to merge? Would you do the honors? |
mp911de
added
type: feature
mp911de
pushed a commit
that referenced
this pull request
Jan 3, 2024
Set GEOSEARCH as read-only command to allow running the command on replicas. Original pull request: #2569
mp911de
pushed a commit
that referenced
this pull request
Jan 3, 2024
Set GEOSEARCH as read-only command to allow running the command on replicas. Original pull request: #2569
|
Thank you for your contribution. That's merged, polished, and backported now. |
Awesome! Thanks to you too! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2568
Set GEOSEARCH as read-only command to allow running the command on replicas. Works similar to #2198.