-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to stabilize integration tests #2825
Attempt to stabilize integration tests #2825
Conversation
…ubSsl more stable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2825 +/- ##
============================================
- Coverage 78.71% 77.74% -0.97%
- Complexity 6786 7244 +458
============================================
Files 508 539 +31
Lines 22765 24494 +1729
Branches 2446 2607 +161
============================================
+ Hits 17919 19044 +1125
- Misses 3717 4257 +540
- Partials 1129 1193 +64 ☔ View full report in Codecov by Sentry. |
…build, disable shard pubsub test that fails
src/test/java/io/lettuce/core/cluster/pubsub/RedisClusterPubSubConnectionIntegrationTests.java
Show resolved
Hide resolved
src/test/java/io/lettuce/core/cluster/pubsub/RedisClusterPubSubConnectionIntegrationTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments to include the tests back.
…ClusterPubSubConnectionIntegartionTests
…ts have completed
src/test/java/io/lettuce/core/cluster/pubsub/RedisClusterPubSubConnectionIntegrationTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks for tailoring the listener bits.
Addressing several stability issues with the pipeline:
failsafe
plugin to theverify
step, as suggested by the Maven best manual-B
option in theMakefile
to improve readability in the logsio.lettuce.core.SslIntegrationTests.pubSubSsl
to attempt to verify the re-subscription process for a longer period of time, as it seems on the runners it takes more than 10 seconds (more than 60 seconds really)io.lettuce.core.cluster.pubsub.RedisClusterPubSubConnectionIntegrationTests.subscribeToShardChannelViaOtherEndpoint
to instead test replica scenario, see discussion belowtestRegularClientPubSubShardChannels
testMake sure that: