Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to stabilize integration tests #2825

Merged
merged 17 commits into from
Apr 19, 2024

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented Apr 11, 2024

Addressing several stability issues with the pipeline:

  1. Failing Integration tests would not fail the pipeline checks - this resulted in several tests constantly failing, and the number was rising. To address this I've added the failsafe plugin to the verify step, as suggested by the Maven best manual
  2. Removed the -B option in the Makefile to improve readability in the logs
  3. Modified the io.lettuce.core.SslIntegrationTests.pubSubSsl to attempt to verify the re-subscription process for a longer period of time, as it seems on the runners it takes more than 10 seconds (more than 60 seconds really)
  4. Modified the io.lettuce.core.cluster.pubsub.RedisClusterPubSubConnectionIntegrationTests.subscribeToShardChannelViaOtherEndpoint to instead test replica scenario, see discussion below
  5. Finished and enabled the testRegularClientPubSubShardChannels test

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun tishun marked this pull request as draft April 11, 2024 11:11
@tishun tishun requested a review from atakavci April 11, 2024 11:11
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.74%. Comparing base (43843bf) to head (40c29d8).
Report is 250 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2825      +/-   ##
============================================
- Coverage     78.71%   77.74%   -0.97%     
- Complexity     6786     7244     +458     
============================================
  Files           508      539      +31     
  Lines         22765    24494    +1729     
  Branches       2446     2607     +161     
============================================
+ Hits          17919    19044    +1125     
- Misses         3717     4257     +540     
- Partials       1129     1193      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments to include the tests back.

@tishun tishun marked this pull request as ready for review April 16, 2024 12:18
@tishun tishun marked this pull request as draft April 16, 2024 15:05
@tishun tishun self-assigned this Apr 18, 2024
@tishun tishun marked this pull request as ready for review April 18, 2024 10:30
Copy link
Collaborator

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for tailoring the listener bits.

@tishun tishun merged commit 5010dc2 into redis:main Apr 19, 2024
5 of 6 checks passed
@tishun tishun deleted the topic/tishun/attempt-to-stabilize-tests branch April 19, 2024 11:02
@tishun tishun added the type: task A general task label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants