Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document update regarding addressResolverGroup settings #3007

Merged
merged 6 commits into from
Oct 18, 2024
Merged

document update regarding addressResolverGroup settings #3007

merged 6 commits into from
Oct 18, 2024

Conversation

winguse
Copy link
Contributor

@winguse winguse commented Oct 7, 2024

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

this PR is mostly a follow up of the missing document update of #1498

tishun
tishun reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much for the contribution!

docs/advanced-usage.md Show resolved Hide resolved
@tishun tishun added the type: documentation A documentation update label Oct 10, 2024
@tishun tishun added this to the 6.5.0.RELEASE milestone Oct 10, 2024
@tishun tishun merged commit 459d4ea into redis:main Oct 18, 2024
5 checks passed
@winguse winguse deleted the patch-1 branch October 27, 2024 03:48
thachlp pushed a commit to thachlp/lettuce that referenced this pull request Dec 31, 2024
@winguse @thachlp
document update regarding addressResolverGroup settings (redis#3007)
30e91f5 
* Update advanced-usage.md

* update doc

* update doc

* pr comments (sorry for getting back late)

* wrap with actual DnsAddressResolverGroup

* use space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tishun tishun tishun approved these changes

Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
6.5.0.RELEASE
Development

Successfully merging this pull request may close these issues.
2 participants
@winguse @tishun