Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubscribe logic ignoring Pub/Sub shard channels after reconnect. #2940 #3024

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Oct 24, 2024

Closes #2940

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@ggivo ggivo force-pushed the 2940-resubscribe-ignoring-sshardchannels branch from d4aee34 to f4e7242 Compare October 24, 2024 06:25
@ggivo ggivo requested a review from tishun October 24, 2024 06:26
@ggivo ggivo self-assigned this Oct 24, 2024
@ggivo ggivo added the type: bug A general bug label Oct 24, 2024
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tishun tishun merged commit 8114354 into redis:main Oct 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resubscribe logic looks ignoring sharded Pub/Sub (shardChannels Set of PubSubEndpoint)
2 participants