Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpsForGeo producing "READONLY You can't write against a read only replica " on READS... #3032

Merged
merged 4 commits into from
Nov 5, 2024
Merged

OpsForGeo producing "READONLY You can't write against a read only replica " on READS... #3032

merged 4 commits into from
Nov 5, 2024

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Oct 30, 2024

only if master & replica configured

Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behavior between Cluster and Redis Standalone/Replica arrangements

Relates to issues #1481 #2568 #2871

Closes #1813

Make sure that:

  • [+] You have read the contribution guidelines.
  • [+] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • [+] You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • [+] You submit test cases (unit or integration tests) that back your changes.

@ggivo
OpsForGeo producing "READONLY You can't write against a read only rep…
cfd82d5 
…lica" on READS... only if master & replica configured redis#1813

Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO
This will unify the behaviour between Cluster and Redis Standalone/Replica arrangements

Relates to  issues redis#1481 redis#2568 redis#2871

Closes redis#1813
@ggivo ggivo changed the title OpsForGeo producing "READONLY You can't write against a read only replica " on READS... #1813 OpsForGeo producing "READONLY You can't write against a read only replica " on READS... Oct 30, 2024
@ggivo ggivo self-assigned this Oct 30, 2024
@ggivo
Copy link
Contributor Author

ggivo commented Oct 30, 2024 •
edited
Loading

A bit of background..

  1. #1481 - Introduces divert to _RO variant of georadius for Redis Cluster Connections
  2. #2568 - georadius commands added to READONLY commands list. Causing error "READONLY You can't write against a read-only replica " when using read-only replica nodes
  3. #2832 Remove georadius from READONLY commands list

@ggivo ggivo marked this pull request as draft October 30, 2024 08:54
@ggivo ggivo marked this pull request as ready for review October 30, 2024 09:28
tishun
tishun approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tishun
Copy link
Collaborator

tishun commented Oct 30, 2024

Let's merge it after we release 6.5.0.RELEASE

@tishun tishun merged commit 39682dc into redis:main Nov 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tishun tishun tishun approved these changes

Assignees

@ggivo ggivo

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ggivo @tishun