fix #1864 - cluster.quit (#1886)

redis · Jan 31, 2022 · 46b831c · 46b831c
1 parent 8160fa7
commit 46b831c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/packages/client/lib/cluster/cluster-slots.ts b/packages/client/lib/cluster/cluster-slots.ts
@@ -232,10 +232,21 @@ export default class RedisClusterSlots<M extends RedisModules, S extends RedisSc
         return this.#nodeByUrl.get(url);
     }
 
-    async disconnect(): Promise<void> {
-        await Promise.all(
-            [...this.#nodeByUrl.values()].map(({ client }) => client.disconnect())
-        );
+    quit(): Promise<void> {
+        return this.#destroy(client => client.quit());
+    }
+
+    disconnect(): Promise<void> {
+        return this.#destroy(client => client.disconnect());
+    }
+
+    async #destroy(fn: (client: RedisClientType<M, S>) => Promise<unknown>): Promise<void> {
+        const promises = [];
+        for (const { client } of this.#nodeByUrl.values()) {
+            promises.push(fn(client));
+        }
+
+        await Promise.all(promises);
 
         this.#nodeByUrl.clear();
         this.#slots.splice(0);

diff --git a/packages/client/lib/cluster/index.ts b/packages/client/lib/cluster/index.ts
@@ -191,6 +191,10 @@ export default class RedisCluster<M extends RedisModules, S extends RedisScripts
         return this.#slots.getSlotMaster(slot);
     }
 
+    quit(): Promise<void> {
+        return this.#slots.quit();
+    }
+
     disconnect(): Promise<void> {
         return this.#slots.disconnect();
     }