Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Redis 6 auth pass [user] #1508

Merged
merged 15 commits into from
Mar 17, 2021
Merged

Conversation

gkorland
Copy link
Contributor

@gkorland
Copy link
Contributor Author

gkorland commented Apr 6, 2020

@Salakar can you please review it?

@stockholmux stockholmux marked this pull request as ready for review April 6, 2020 19:40
@gkorland
Copy link
Contributor Author

@stockholmux I don't see, what am I missing?

@farzadso
Copy link

farzadso commented Jul 8, 2020

@gkorland Any updates on this?

@gkorland
Copy link
Contributor Author

@Salakar can you please review this PR?

@farzadso
Copy link

@gkorland Looks good to me.

@gkorland
Copy link
Contributor Author

@Salakar can you please review this PR?

stockholmux
stockholmux previously approved these changes Nov 24, 2020
Copy link
Contributor

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farzadso
Copy link

farzadso commented Dec 8, 2020

Any updates on this?

@gkorland gkorland requested a review from leibale March 4, 2021 17:02
@farzadso
Copy link

farzadso commented Mar 6, 2021

Will this ever be merged?

@leibale
Copy link
Collaborator

leibale commented Mar 6, 2021

Not yet, it will be in the next couple if days

lib/individualCommands.js Outdated Show resolved Hide resolved
leibale
leibale previously approved these changes Mar 8, 2021
@@ -61,7 +61,7 @@ describe('client authentication', function () {
});
var tmp = client.command_queue.get(0).callback;
client.command_queue.get(0).callback = function (err, res) {
client.auth = function (pass, callback) {
client.auth = function (pass, user, callback) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leibale shouldn't we keep the original test too? for backward?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkorland overriding a function on the client is not part of the API..

@gkorland
Copy link
Contributor Author

gkorland commented Mar 9, 2021

@leibale why does the lint fail?

@leibale
Copy link
Collaborator

leibale commented Mar 9, 2021

@gkorland IDK whats doing on, it seems like it's running old workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants