Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

CSS issue in headings #150

Open
philraj opened this issue Aug 2, 2018 · 3 comments · May be fixed by #254
Open

CSS issue in headings #150

philraj opened this issue Aug 2, 2018 · 3 comments · May be fixed by #254

Comments

@philraj
Copy link

philraj commented Aug 2, 2018

image

There's an issue with the hover state of headings where the anchor that appears is clipped by the overflow: hidden defined on articles.

@KartikSoneji
Copy link

It has been over 3 years.
@djanowski apologies for pinging you like this, but will a PR for this issue be accepted?

@itamarhaber
Copy link
Member

Hi @KartikSoneji - we'd appreciate you submitting a PR that resolves this issue (regrettably, my CSS skills lacking).

KartikSoneji added a commit to KartikSoneji/redis-io that referenced this issue Oct 11, 2021
KartikSoneji added a commit to KartikSoneji/redis-io that referenced this issue Oct 11, 2021
@KartikSoneji KartikSoneji linked a pull request Oct 11, 2021 that will close this issue
@KartikSoneji
Copy link

I have opened a PR: #254

article { overflow: hidden; *zoom: 1; }

@media only screen and (min-width: 992px) { article { display: block; width: 102.08333%; margin: 0 -1.04167%; overflow: hidden; *zoom: 1; }

The issue is article and @media only screen and (min-width: 992px) article set overflow: hidden.
I am not sure what it does, but the site looks the exact same to me without it.

Also, *zoom: 1; is a hack for targeting IE 5.5, IE6, and IE7, I am not sure we need it anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants