[WIP] codebase refactor. #332
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following steps were performed:
keysmethod call.filtermethod with a list comprehension to increase readability.Replaced old python2 methods with their equivalent in python3 (e.g.didn't notice the use ofxrange->range,izip->zip)sixmodule.f-stringswhenever possible because it is the ultimate method for string formatting.sortedmethod because it takes aniterablewhich is in this case a generator.Found and fixed a syntax error:.typ is not str->not isinstance(typ, str)None not inwithall.Question: Why the cache size is set to None? This can become problematic as explained here.