Skip to content

Bump pydantic version #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bump pydantic version #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ include=[
[tool.poetry.dependencies]
python = ">=3.8,<4.0"
redis = ">=3.5.3,<5.0.0"
pydantic = ">=1.10.2,<2.1.0"
pydantic = ">=1.10.2,<3.0.0"
Copy link

@patrick91 patrick91 Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the upper bound entirely, see this article: https://arc.net/l/quote/txkfghki

Copy link
Author

@khiemdoan khiemdoan Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with that.
Pydantic v3 would have breaking changes, see: Pydantic V3 and beyond
Nothing promises it will be compatible with older versions. Especially this library is still both Pydantic v1 and v2.

Copy link

@patrick91 patrick91 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that'd be the cause, but there might be a chance where this library wouldn't be affected by the breaking changes :)
And if you're affected by the breaking changes you can pin your side 😊

click = "^8.0.1"
types-redis = ">=3.5.9,<5.0.0"
python-ulid = "^1.0.3"
Expand Down