Fix issue with pack_commands returning an empty byte sequence (#2416)

Co-authored-by: dvora-h <67596500+dvora-h@users.noreply.github.com>
redis · Feb 7, 2023 · f517287 · f517287
1 parent fcd8f98
commit f517287
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/redis/asyncio/connection.py b/redis/asyncio/connection.py
@@ -925,7 +925,8 @@ def pack_commands(self, commands: Iterable[Iterable[EncodableT]]) -> List[bytes]
                     or chunklen > buffer_cutoff
                     or isinstance(chunk, memoryview)
                 ):
-                    output.append(SYM_EMPTY.join(pieces))
+                    if pieces:
+                        output.append(SYM_EMPTY.join(pieces))
                     buffer_length = 0
                     pieces = []
 

diff --git a/redis/connection.py b/redis/connection.py
@@ -976,7 +976,8 @@ def pack_commands(self, commands):
                     or chunklen > buffer_cutoff
                     or isinstance(chunk, memoryview)
                 ):
-                    output.append(SYM_EMPTY.join(pieces))
+                    if pieces:
+                        output.append(SYM_EMPTY.join(pieces))
                     buffer_length = 0
                     pieces = []