always clear reference to closed reader/writer (#2077)

* always clear reference to reader/writer * add #2065 to changes
redis · Apr 4, 2022 · ff93817 · ff93817
1 parent 51a4dd9
commit ff93817
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES b/CHANGES
@@ -6,6 +6,7 @@
     * Fix cursor returned by SCAN for RedisCluster & change default target to PRIMARIES
     * Fix scan_iter for RedisCluster
     * Remove verbose logging when initializing ClusterPubSub, ClusterPipeline or RedisCluster
+    * Fix broken connection writer lock-up for asyncio (#2065)
 
 * 4.1.3 (Feb 8, 2022)
     * Fix flushdb and flushall (#1926)

diff --git a/redis/asyncio/connection.py b/redis/asyncio/connection.py
@@ -827,8 +827,9 @@ async def disconnect(self):
                             await self._writer.wait_closed()  # type: ignore[union-attr]
                 except OSError:
                     pass
-                self._reader = None
-                self._writer = None
+                finally:
+                    self._reader = None
+                    self._writer = None
         except asyncio.TimeoutError:
             raise TimeoutError(
                 f"Timed out closing connection after {self.socket_connect_timeout}"