Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort start/num check is broken #1

Closed
orph opened this issue Nov 20, 2009 · 2 comments
Closed

sort start/num check is broken #1

orph opened this issue Nov 20, 2009 · 2 comments

Comments

@orph
Copy link

orph commented Nov 20, 2009

0 is False in Python, so passing start=0, num=20 to sort will return all the results.

Line 676:
if start and num
Should be:
if start != None and num != None:
@andymccurdy
Copy link
Contributor

closed by d09367d by checking for None rather than boolean on sort params since 0 is valid.

@andymccurdy
Copy link
Contributor

Thanks! Commited to github in d09367d, will be available in the next release.

@cogbee cogbee mentioned this issue Jan 14, 2016
Closed
andymccurdy pushed a commit that referenced this issue Jun 14, 2016
@cjsimpson
Merge pull request #1 from andymccurdy/master
360c212 
sync with origin
@exit99 exit99 mentioned this issue Jun 14, 2016
Closed
andymccurdy pushed a commit that referenced this issue Nov 5, 2018
@itamarhaber
Merge pull request #1 from RoeyPrat/unblock
9a5d994 
Remove reason arg from client_unblock. Use boolean 'error' arg instead.

xref: #1036 (review)
andymccurdy pushed a commit that referenced this issue Jan 27, 2019
Merge pull request #1 from RoeyPrat/roey-pycodestyle_oridistor
62f1f19 
pycodestyle fixes to connection.py
@atdt atdt mentioned this issue Sep 1, 2020
Closed
@chayim chayim mentioned this issue Jul 29, 2021
Merged
chayim pushed a commit that referenced this issue Dec 2, 2021
@AvitalFineRedis
Merge pull request #1 from redis/master
da0b3fa 
Merge master
bellatoris pushed a commit to bellatoris/redis-py that referenced this issue Jul 13, 2023
@zach-iee
Merge existing changes to the forked version (redis#1)
28d80e1 
* [GROW-2938] do not reset redis_connection on an error

* [GROW-2938] add backoff to more errors

* [GROW-2938] recover from SlotNotCoveredError

* [GROW-2938] prevent get_node_from_slot from failing due to concurrent cluster slots refresh

* [GROW-2938] add retry to ClusterPipeline

(cherry picked from commit 63e06dd)
bellatoris pushed a commit to bellatoris/redis-py that referenced this issue Jul 13, 2023
@zach-iee
[GROW-2938] additional test to redis#1 (redis#2)
05bf98c 
* [GROW-2938] add a test for invalid index returned from load balancer

* [GROW-2938] add a test for pipeline additional backoff

(cherry picked from commit 308c82b)
@chayim chayim mentioned this issue Aug 31, 2023
Merged
6 tasks
@851459955 851459955 mentioned this issue Oct 18, 2023
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orph @andymccurdy