Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need examples! #1744

Open
chayim opened this issue Nov 23, 2021 · 12 comments · Fixed by #1916
Open

We need examples! #1744

chayim opened this issue Nov 23, 2021 · 12 comments · Fixed by #1916
Labels
good first issue help-wanted maintenance Maintenance (CI, Releases, etc)

Comments

@chayim
Copy link
Contributor

chayim commented Nov 23, 2021

In order to help drive adoption, and make it easier for others to get started with redis-py, I'd love to start including examples with the repository. Recently, I introduced a change to start splitting up the documentation - as a first step - which will be part of 4.1.0.

Next - I plan on adding support for jupyter notebooks in our documentation to enable this.

@santosh
Copy link

santosh commented Dec 1, 2021

What are some action items?

@chayim
Copy link
Contributor Author

chayim commented Dec 1, 2021

@santosh Off the top of my head I think of:

@dogukanteber
Copy link
Contributor

@chayim I would like to hop on that. Can you give a more detailed description of how should one construct these examples?

@chayim
Copy link
Contributor Author

chayim commented Jan 27, 2022

@dogukanteber awesome! Sure, here's a detailed process based on what's now in. To write jupyter notebooks (I'm awful at this!). I learned from this tutorial, and to be honest, I use a VSCode plugin when I need to edit things.

  1. Add your new notebook (or edit an exiting file) to docs/examples.
  2. Add your notebook to docs/examples.rst
  3. Create a new virtualenv and ensure you have dev dependencies ready (pip install -r dev_requirements.txt)
  4. To test the things you've built and see how they look in the generated documentation run invoke build-docs
  5. Go to docs/_build/html )(this is where the files are generated), and run python3 -m http.server
  6. Open your browser to http://localhost:8080 and view the docs.

@chayim
Copy link
Contributor Author

chayim commented Feb 6, 2022

Reopening - sorry didn't mean to close this.

@chayim chayim reopened this Feb 6, 2022
@Iglesys347
Copy link
Contributor

Hi @chayim, I don't know if you still need help on this issue, but I created an example notebook of Redis pipelines at #2240

@chayim
Copy link
Contributor Author

chayim commented Jun 21, 2022

I left this open for exactly that reason @Iglesys347 . I tagged you there.

@Garito
Copy link

Garito commented Jul 7, 2022

There is a lack of timeseries tutorials, for instance

@chayim
Copy link
Contributor Author

chayim commented Sep 1, 2022

@sav-norem. Wanna?

@LX5321
Copy link

LX5321 commented Mar 13, 2023

Hey @chayim are contributions on this issue still being entertained?

Would love to add some examples..

@chayim
Copy link
Contributor Author

chayim commented Mar 15, 2023

@LX5321 always :D. More than entertained - we'd love them.

@CarlFK
Copy link

CarlFK commented Feb 19, 2024

wandering about the internet, I have come across some posts like:
https://realpython.com/python-redis/#getting-started

Any objection to posting more of these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help-wanted maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants