-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LMOVE, BLMOVE return incorrect response #1776
Comments
@varunchopra Thank you! By all means, I'd love to see that :). At the same time, please notice that BLMOVE returns a Bulk string or a Null reply whereas LMOVE returns a bulk string. Since you kindly offered, I assigned this to you. |
I'm sorry I don't understand. Isn't the behavior already correct once the bool conversion is removed? I've looked at similar implementations and it seems to be alright. Will send a PR. |
@varunchopra Apologies, apparently I wasn't clear. You are correct. That removal ought solve this issue. |
Version:
redis-py: 4.0.2
Redis server: 6.2.3 (enterprise)
Platform:
3.8.10, Ubuntu 20
Description:
According to the docs and the latest redis CLI, LMOVE and BLMOVE must return the value of the key that is being moved.
To repro:
However, these return bool on redis-py:
I believe these were erroneously added in
RESPONSE_CALLBACKS
in #1504 and the fix is to remove this.@chayim Please let me know if I'm correct and I can create a PR as well.
The text was updated successfully, but these errors were encountered: