-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis.select() requires host and port #21
Comments
The additional arguments were intentionally added to make the user realize that they're switching the underlying TCP connection whenever they switch the database. I suppose the current host/port could be used if changing to a different database and those arguments weren't provided. |
That's what I would have expected. However, as a user, it isn't a big deal to imitate that behavior with the existing implementation. In any event, I would recommend either changing the documentation or the method signature/ semantics so that the two are in sync. |
Ok, this has been fixed and commited in c148ede |
… If host and port aren't specified, the host/port options on the existing connection are used. * added HINCRBY support
From the documentation for the
select
method ofRedis
:However,
host
andport
are required parameters:Can we make host and port optional, with
db
the only required parameter?The text was updated successfully, but these errors were encountered: