Skip to content

sdist is missing tox.ini #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mtelka opened this issue Dec 8, 2022 · 3 comments
Closed

sdist is missing tox.ini #2493

mtelka opened this issue Dec 8, 2022 · 3 comments

Comments

@mtelka
Copy link

mtelka commented Dec 8, 2022

The sdist package at PyPI is missing tox.ini. Please add the file to the sdist to make downstream testing easier. Thank you.

@chayim
Copy link
Contributor

chayim commented Dec 8, 2022

Hi @mtelka, thanks for reporting this.

Maybe I can help - what are you trying to accomplish? I ask, because ideally we wouldn't include dev depencencies (dev_requirements.txt) and configurations (such as tox-docker) in the release package.

@mtelka
Copy link
Author

mtelka commented Dec 8, 2022

I'm trying to package redis 4.4.0 for OpenIndiana. To do so I use sdist (we always use sdist to package Python projects). The packaging process includes testing to make sure the package is okay. Currently, with the latest sdist, we need to run pytest directly because there is missing tox.ini so we cannot use the (preferred) tox based testing. Since redis needs some Python packages for testing (e.g. pytest-async) we need to specify them manually as testing dependencies. If there is tox.ini included in the sdist (with all related files) the testing dependencies could be automatically detected and fulfilled by our building/packaging framework.

Thanks.

@mtelka
Copy link
Author

mtelka commented Nov 29, 2023

tox.ini was removed from git so there is nothing to add to sdist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants