Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist is missing few files needed to run tests #3057

Closed
mtelka opened this issue Nov 29, 2023 · 3 comments
Closed

sdist is missing few files needed to run tests #3057

mtelka opened this issue Nov 29, 2023 · 3 comments
Assignees
Labels

Comments

@mtelka
Copy link

mtelka commented Nov 29, 2023

I'm packaging redis-py 5.0.1 for OpenIndiana and I found that there are few files missing from sdist to see testing passed. Please note that all tests are already included in sdist and we miss only few supporting files:

  • dockers/stunnel/keys/server-cert.pem
  • pytest.ini
  • dev_requirements.txt - this file is not needed to get tests passed, it would be just a convenience to easily find modules required for testing.

Please add above files to sdist to make downstream packaging and testing easier.

Thank you.

PS: Related: #2493

@petyaslavova
Copy link
Collaborator

Hi @mtelka , is this change still needed?

@petyaslavova petyaslavova assigned petyaslavova and unassigned chayim Feb 11, 2025
@mtelka
Copy link
Author

mtelka commented Feb 11, 2025

Yes, it is. Thank you.

@petyaslavova
Copy link
Collaborator

Fixed in master branch.
The file 'dockers/stunnel/keys/server-cert.pem' is not included, because it is no longer part of the repo files.
The change will be part of the next stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants