Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclusive gt and lt in zadd #1533

Merged
merged 2 commits into from
Aug 3, 2021
Merged

exclusive gt and lt in zadd #1533

merged 2 commits into from
Aug 3, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 1, 2021

No description provided.

@@ -2905,6 +2905,8 @@ def zadd(self, name, mapping, nx=False, xx=False, ch=False, incr=False,
"single element/score pair")
if nx is True and (gt is not None or lt is not None):
raise DataError("Only one of 'nx', 'lt', or 'gr' may be defined.")
if gt is not None and lt is not None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add lt and gt to the docstring while you're at it?

Copy link
Contributor

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chayim chayim merged commit 3c0e116 into redis:master Aug 3, 2021
@chayim chayim deleted the ck-zadd-excls branch September 1, 2021 11:14
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
exclusive gt and lt in zadd (redis/redis-py#1533)

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants