Skip to content

Adding EXAT and PXAT (unix time support) support for SET #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Aug 19, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@AvitalFineRedis
Copy link
Contributor Author

#1546

@AvitalFineRedis
Copy link
Contributor Author

@chayim,
Can you please see why it failing:
ERROR: pypy3-hiredis: commands failed

@chayim chayim changed the title set with unix time Adding EXAT and PXAT (unix time support) support for SET Aug 29, 2021
@chayim
Copy link
Contributor

chayim commented Aug 29, 2021

Seems non-deterministic currently. I'm going to let it bake a bit longer and see what happens.

@chayim chayim merged commit de9922a into redis:master Sep 1, 2021
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
Adding EXAT and PXAT (unix time support) support for SET (redis/redis-py#1547)

* Fix additional type annotations I (@Andrew-Chen-Wang) made with ExpiryT

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants