Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CLIENT TRACKING #1612

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Oct 14, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim added 4.0.+ feature New feature labels Nov 15, 2021
@chayim chayim added 4.1.0 and removed 4.0.+ labels Nov 29, 2021
@chayim chayim marked this pull request as ready for review December 22, 2021 09:11
@chayim chayim changed the title Support CLIENT TRACKING (missing tests) Support CLIENT TRACKING Dec 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #1612 (5a50825) into master (e0d3ba5) will increase coverage by 0.00%.
The diff coverage is 85.29%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1612   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files          75       75           
  Lines       15835    15869   +34     
=======================================
+ Hits        14934    14967   +33     
- Misses        901      902    +1     
Impacted Files Coverage Δ
redis/commands/core.py 89.88% <76.19%> (-0.21%) ⬇️
tests/test_commands.py 99.38% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 98.79% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d3ba5...5a50825. Read the comment docs.

@chayim chayim merged commit 139bcbb into redis:master Dec 22, 2021
@AvitalFineRedis AvitalFineRedis deleted the client_tracking branch December 23, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants