Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ck testfixes #1696

Merged
merged 6 commits into from
Nov 10, 2021
Merged

ck testfixes #1696

merged 6 commits into from
Nov 10, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 10, 2021

  • Fixing multiprocessing tests to respect redisurl ports
  • test improvement: do not fill modules information if no modules present
  • Marking module loader as redismod

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #1696 (139415b) into master (776dd59) will decrease coverage by 0.01%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1696      +/-   ##
==========================================
- Coverage   92.24%   92.22%   -0.02%     
==========================================
  Files          53       53              
  Lines       10994    11002       +8     
==========================================
+ Hits        10141    10147       +6     
- Misses        853      855       +2     
Impacted Files Coverage Δ
tests/conftest.py 95.07% <63.63%> (-1.28%) ⬇️
tests/test_connection.py 80.55% <100.00%> (+1.14%) ⬆️
tests/test_connection_pool.py 100.00% <100.00%> (ø)
tests/test_monitor.py 100.00% <100.00%> (ø)
tests/test_multiprocessing.py 100.00% <100.00%> (ø)
tests/test_pubsub.py 99.73% <100.00%> (ø)
tests/test_sentinel.py 99.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776dd59...139415b. Read the comment docs.

@chayim chayim merged commit 5be96b9 into master Nov 10, 2021
@chayim chayim deleted the ck-testfixes branch November 10, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants