Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call HSET after FT.CREATE to avoid keyspace scan #1706

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Nov 14, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2021

Codecov Report

Merging #1706 (d10fcc5) into master (19819e0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1706   +/-   ##
=======================================
  Coverage   89.06%   89.06%           
=======================================
  Files          53       53           
  Lines       11071    11071           
=======================================
  Hits         9860     9860           
  Misses       1211     1211           
Impacted Files Coverage Δ
tests/test_search.py 98.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19819e0...d10fcc5. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 14, 2021
@chayim chayim changed the title [TEST] Call HSET after FT.CREATE to avoid keyspace scan Call HSET after FT.CREATE to avoid keyspace scan Nov 14, 2021
@chayim chayim merged commit c8cb715 into redis:master Nov 14, 2021
@ashtul ashtul deleted the ariel_fix-alias-test branch April 6, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants