Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BLMPOP #1849

Merged
merged 11 commits into from
Feb 2, 2022
Merged

Add support for BLMPOP #1849

merged 11 commits into from
Feb 2, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 4, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Add support for BLMPOP (redis 7) #1799

@dvora-h dvora-h requested a review from chayim January 4, 2022 07:36
@dvora-h dvora-h added the feature New feature label Jan 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1849 (25d1919) into master (aaddeb6) will decrease coverage by 11.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1849       +/-   ##
===========================================
- Coverage   92.99%   81.11%   -11.88%     
===========================================
  Files          76       76               
  Lines       16524    16536       +12     
===========================================
- Hits        15366    13413     -1953     
- Misses       1158     3123     +1965     
Impacted Files Coverage Δ
redis/commands/core.py 90.15% <100.00%> (+0.02%) ⬆️
tests/test_commands.py 99.22% <100.00%> (-0.18%) ⬇️
tests/test_cluster.py 17.50% <0.00%> (-80.66%) ⬇️
redis/cluster.py 22.22% <0.00%> (-70.21%) ⬇️
redis/commands/cluster.py 34.48% <0.00%> (-60.35%) ⬇️
redis/crc.py 40.00% <0.00%> (-60.00%) ⬇️
redis/utils.py 75.00% <0.00%> (-13.89%) ⬇️
redis/exceptions.py 86.56% <0.00%> (-11.95%) ⬇️
tests/conftest.py 79.72% <0.00%> (-10.37%) ⬇️
redis/retry.py 95.83% <0.00%> (-4.17%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaddeb6...25d1919. Read the comment docs.


For more information check https://redis.io/commands/blmpop
"""
args = [timeout, num_keys] + list(args) + [direction]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as SINTERCARD PR on construction. This can be done via:

args = [timeout, num_keys, *args, direction]

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT?

@dvora-h dvora-h requested a review from chayim January 13, 2022 12:37
@chayim chayim added the redis-7 label Jan 16, 2022
redis/commands/core.py Outdated Show resolved Hide resolved
@dvora-h dvora-h merged commit 4d7de6d into redis:master Feb 2, 2022
@dvora-h dvora-h deleted the add-blmpop branch February 2, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants