-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for BLMPOP #1849
Add support for BLMPOP #1849
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1849 +/- ##
===========================================
- Coverage 92.99% 81.11% -11.88%
===========================================
Files 76 76
Lines 16524 16536 +12
===========================================
- Hits 15366 13413 -1953
- Misses 1158 3123 +1965
Continue to review full report at Codecov.
|
redis/commands/core.py
Outdated
|
||
For more information check https://redis.io/commands/blmpop | ||
""" | ||
args = [timeout, num_keys] + list(args) + [direction] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as SINTERCARD PR on construction. This can be done via:
args = [timeout, num_keys, *args, direction]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT?
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Add support for BLMPOP (redis 7) #1799