Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CLUSTER ADDSLOTSRANGE #2017

Merged
merged 6 commits into from
Mar 14, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Feb 23, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.
closes #1802

@dvora-h dvora-h added feature New feature redis-7 labels Feb 23, 2022
@dvora-h dvora-h requested a review from chayim February 23, 2022 11:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #2017 (3ee7c64) into master (4a714aa) will decrease coverage by 0.47%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
- Coverage   92.63%   92.16%   -0.48%     
==========================================
  Files         100      100              
  Lines       20909    21005      +96     
==========================================
- Hits        19369    19359      -10     
- Misses       1540     1646     +106     
Impacted Files Coverage Δ
redis/client.py 89.39% <ø> (ø)
redis/cluster.py 91.93% <ø> (-0.58%) ⬇️
tests/test_cluster.py 98.23% <40.00%> (-0.06%) ⬇️
redis/commands/cluster.py 94.11% <100.00%> (-0.71%) ⬇️
tests/test_function.py 25.30% <0.00%> (-74.70%) ⬇️
redis/commands/timeseries/__init__.py 94.73% <0.00%> (-5.27%) ⬇️
redis/commands/json/__init__.py 97.56% <0.00%> (-2.44%) ⬇️
redis/commands/parser.py 88.40% <0.00%> (-1.92%) ⬇️
redis/commands/core.py 85.86% <0.00%> (-1.36%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a714aa...3ee7c64. Read the comment docs.

@dvora-h dvora-h merged commit 9376ed8 into redis:master Mar 14, 2022
@dvora-h dvora-h deleted the add-cluster-addslotsrange branch March 14, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for CLUSTER ADDSLOTSRANGE
3 participants