Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect return statement in auth (#2086) #2092

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Fix incorrect return statement in auth (#2086) #2092

merged 1 commit into from
Apr 27, 2022

Conversation

kamyabzad
Copy link
Contributor

@kamyabzad kamyabzad commented Apr 7, 2022

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Was the change added to CHANGES file?

Description of change

Fix a bug in commands.core.ManagementCommands.auth that returned a function handler when provided with a None username

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #2092 (226eb22) into master (cb91eed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2092   +/-   ##
=======================================
  Coverage   92.45%   92.46%           
=======================================
  Files         104      104           
  Lines       24364    24365    +1     
=======================================
+ Hits        22526    22528    +2     
+ Misses       1838     1837    -1     
Impacted Files Coverage Δ
redis/commands/core.py 84.04% <100.00%> (+0.03%) ⬆️
tests/test_commands.py 94.32% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb91eed...226eb22. Read the comment docs.

redis/commands/core.py Outdated Show resolved Hide resolved
@chayim
Copy link
Contributor

chayim commented Apr 11, 2022

@kamyabzad thanks for the contribution! Curious what your thoughts are on the suggestion above

@kamyabzad
Copy link
Contributor Author

@chayim Thanks for the suggestion, I like it more. I have updated the code and the tests (also rebased onto upstream).

@chayim
Copy link
Contributor

chayim commented Apr 11, 2022

@kamyabzad This looks great! I think it's good to merge into the next release.

Thanks again, for both pointing out the issue, and fixing it!

@kamyabzad
Copy link
Contributor Author

@kamyabzad This looks great! I think it's good to merge into the next release.

Thanks again, for both pointing out the issue, and fixing it!

@kamyabzad kamyabzad closed this Apr 11, 2022
@kamyabzad kamyabzad reopened this Apr 11, 2022
@chayim chayim added the bug Bug label Apr 12, 2022
@dvora-h dvora-h merged commit cfebc0f into redis:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants