Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix execute_command() determine nodes error when no key command #2097

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix execute_command() determine nodes error when no key command #2097

merged 1 commit into from
Apr 28, 2022

Conversation

suxb201
Copy link
Contributor

@suxb201 suxb201 commented Apr 8, 2022

see #2095

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #2097 (093e736) into master (805b184) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   92.43%   92.44%           
=======================================
  Files         104      104           
  Lines       24363    24366    +3     
=======================================
+ Hits        22520    22524    +4     
+ Misses       1843     1842    -1     
Impacted Files Coverage Δ
redis/cluster.py 91.72% <66.66%> (-0.11%) ⬇️
tests/test_cluster.py 97.48% <0.00%> (ø)
tests/test_graph.py 90.62% <0.00%> (+0.03%) ⬆️
redis/asyncio/connection.py 84.72% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805b184...093e736. Read the comment docs.

Copy link
Collaborator

@dvora-h dvora-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suxb201 Thank you for reporting this bug and contribute its fix!

@chayim chayim added the bug Bug label Apr 12, 2022
@chayim chayim requested a review from dvora-h April 18, 2022 08:36
@chayim
Copy link
Contributor

chayim commented Apr 18, 2022

@dvora-h note there have been changes since your reviewed fix. I cleared the approved flag as a result.

@suxb201
Copy link
Contributor Author

suxb201 commented Apr 19, 2022

@chayim just did a git rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants