Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CASESENSITIVE for TAG fields #2112

Merged
merged 6 commits into from
Apr 25, 2022

Conversation

Avital-Fine
Copy link
Contributor

@Avital-Fine Avital-Fine commented Apr 19, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Closes #2040

@Avital-Fine Avital-Fine requested review from chayim and dvora-h April 19, 2022 08:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #2112 (a3d2f07) into master (e5e265d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
- Coverage   92.44%   92.43%   -0.02%     
==========================================
  Files         104      104              
  Lines       24364    24383      +19     
==========================================
+ Hits        22524    22538      +14     
- Misses       1840     1845       +5     
Impacted Files Coverage Δ
redis/commands/search/field.py 98.57% <100.00%> (+0.08%) ⬆️
tests/test_search.py 99.19% <100.00%> (+0.01%) ⬆️
tests/test_cluster.py 97.36% <0.00%> (-0.24%) ⬇️
redis/asyncio/connection.py 84.49% <0.00%> (-0.12%) ⬇️
tests/test_graph.py 90.59% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e265d...a3d2f07. Read the comment docs.

@chayim
Copy link
Contributor

chayim commented Apr 24, 2022

@Avital-Fine Any idea why under python 3.9 (hiredis) and only there - we see a unit test failure with the assert?

@Avital-Fine Avital-Fine merged commit 6ba4641 into redis:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CASESENSITIVE tag in Tag Field
4 participants