-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHUTDOWN - add support for the new NOW, FORCE and ABORT modifiers #2150
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2150 +/- ##
==========================================
- Coverage 92.27% 91.89% -0.39%
==========================================
Files 105 108 +3
Lines 25246 27414 +2168
==========================================
+ Hits 23297 25191 +1894
- Misses 1949 2223 +274
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need tests - even if we just mock this....
tests/test_commands.py
Outdated
conn = redis.Redis(port=6380) | ||
conn.shutdown = mock.MagicMock() | ||
conn.shutdown() | ||
conn.shutdown.assert_called_once_with() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add asserts for the various options? Also, let's try the mock on the execute_command call, not the function. Then we can validate the function is called.
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
closes #2126