Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_cluster: add pipeline support #2199

Merged
merged 2 commits into from
May 30, 2022

Conversation

utkarshgupta137
Copy link
Contributor

@utkarshgupta137 utkarshgupta137 commented May 24, 2022

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

Closes #2186

@utkarshgupta137 utkarshgupta137 force-pushed the async_cluster_pipeline branch from a3e9fcd to ea6b3ea Compare May 24, 2022 23:22
@utkarshgupta137 utkarshgupta137 force-pushed the async_cluster_pipeline branch from ea6b3ea to 6ae1c41 Compare May 24, 2022 23:27
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #2199 (59c5bd0) into master (c54dfa4) will increase coverage by 0.15%.
The diff coverage is 96.19%.

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
+ Coverage   91.88%   92.03%   +0.15%     
==========================================
  Files         108      108              
  Lines       27389    27629     +240     
==========================================
+ Hits        25166    25429     +263     
+ Misses       2223     2200      -23     
Impacted Files Coverage Δ
redis/asyncio/cluster.py 90.08% <93.89%> (+0.83%) ⬆️
tests/test_asyncio/test_cluster.py 97.64% <97.97%> (+0.42%) ⬆️
redis/cluster.py 90.00% <100.00%> (-0.35%) ⬇️
tests/test_asyncio/test_pipeline.py 100.00% <100.00%> (ø)
tests/test_commands.py 89.92% <0.00%> (+0.12%) ⬆️
redis/asyncio/client.py 92.85% <0.00%> (+0.17%) ⬆️
tests/test_json.py 100.00% <0.00%> (+0.19%) ⬆️
redis/asyncio/connection.py 83.85% <0.00%> (+0.22%) ⬆️
tests/test_asyncio/test_json.py 100.00% <0.00%> (+0.24%) ⬆️
tests/test_cluster.py 97.14% <0.00%> (+0.35%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c54dfa4...59c5bd0. Read the comment docs.

@utkarshgupta137 utkarshgupta137 force-pushed the async_cluster_pipeline branch 2 times, most recently from 172de34 to 7742741 Compare May 25, 2022 18:46
@utkarshgupta137 utkarshgupta137 marked this pull request as ready for review May 25, 2022 18:53
@dvora-h
Copy link
Collaborator

dvora-h commented May 30, 2022

@utkarshgupta137 This PR also looks awesome, can you please resolve the conflicts with master so we will can merge it too?

@dvora-h dvora-h added the feature New feature label May 30, 2022
@utkarshgupta137 utkarshgupta137 force-pushed the async_cluster_pipeline branch from 7742741 to a8e6a91 Compare May 30, 2022 14:30
@utkarshgupta137 utkarshgupta137 force-pushed the async_cluster_pipeline branch from a8e6a91 to 4f1526a Compare May 30, 2022 14:31
@dvora-h dvora-h merged commit bac33d4 into redis:master May 30, 2022
@utkarshgupta137 utkarshgupta137 deleted the async_cluster_pipeline branch June 2, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing pipeline support for async ClusterClient
3 participants