Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Hiredis >= 1.x only (remove packaging dependency) #2385

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 19, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

This PR:

  • disables hiredis use if hiredis is < 1.0 (i.e. if the version starts with 0.x). This shouldn't be a problem, since Hiredis 1.0 was released in 2019, and the [hiredis] extra has required hiredis >= 1.0 since 4.0 (866ac00).
  • with that, it removes the runtime dependency on packaging, which was only used to determine whether the version of Hiredis in use is recent enough.
  • removes the compatibility code that was required with Hiredis < 1.0.

@akx akx force-pushed the hiredis-1plus-only branch from df460b1 to 6d920c6 Compare September 19, 2022 09:51
@akx akx changed the title Hiredis >= 1.x only Support Hiredis >= 1.x only Sep 19, 2022
@akx akx marked this pull request as ready for review September 19, 2022 10:21
@akx akx changed the title Support Hiredis >= 1.x only Support Hiredis >= 1.x only (remove packaging dependency) Sep 19, 2022
@akx akx force-pushed the hiredis-1plus-only branch from 6d920c6 to 9dcbeae Compare September 21, 2022 10:45
@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Sep 28, 2022
@dvora-h dvora-h merged commit 027abe5 into redis:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants