Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini: fix healtcheck -> healthcheck #2395

Closed
wants to merge 1 commit into from
Closed

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 21, 2022

This could maybe fix the flakiness of some of the cluster tests.

Alternate take on #2387.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

healtcheck_cmd has been typoed in tox.ini since its inception, making it a no-op.

Some CI is failing right now due to what seems to be failure connecting to cluster nodes, so perhaps waiting for them to be up fixes things.

This could maybe fix the flakiness of some of the cluster tests
@dvora-h
Copy link
Collaborator

dvora-h commented Jul 16, 2023

Not relevant anymore (see #2793)

@dvora-h dvora-h closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants