-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding connection step to bloom filter examples #2478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nermiller sorry I didn't articulate this well - the connection will need to be after the import, then the connection name is what needs to be used - also, the return from create is a boolean, it can't actually be used to alter the data structure, so they'll need to be more like
import redis r = redis.Redis() r.bf().create("bloom", .01, 1000) r.bf().add("bloom", "foo")
The return values are pretty much only used as a success / fail / did something change type of measure, they don't return a way to access the object.
Apply feedback
@savynorem please review again. Thanks! |
Codecov ReportBase: 92.22% // Head: 92.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2478 +/- ##
==========================================
- Coverage 92.22% 92.19% -0.03%
==========================================
Files 113 113
Lines 29239 29239
==========================================
- Hits 26965 26958 -7
- Misses 2274 2281 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks great to me!
Fixes #2415, adds a connect step to bloom commands