Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising NotImplementedError for certain LATENC commands #2501

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Dec 11, 2022

closes #1978
closes #1977

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

Base: 92.23% // Head: 92.11% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (cf705d9) compared to base (6219574).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2501      +/-   ##
==========================================
- Coverage   92.23%   92.11%   -0.12%     
==========================================
  Files         113      113              
  Lines       29325    29337      +12     
==========================================
- Hits        27047    27024      -23     
- Misses       2278     2313      +35     
Impacted Files Coverage Δ
redis/commands/core.py 81.99% <50.00%> (-0.08%) ⬇️
tests/test_commands.py 89.75% <50.00%> (-0.20%) ⬇️
tests/test_graph_utils/test_edge.py 94.59% <0.00%> (-2.71%) ⬇️
tests/test_asyncio/test_graph.py 97.68% <0.00%> (-1.55%) ⬇️
tests/test_graph_utils/test_path.py 97.01% <0.00%> (-1.50%) ⬇️
tests/test_graph.py 90.31% <0.00%> (-1.25%) ⬇️
tests/conftest.py 84.94% <0.00%> (-0.78%) ⬇️
redis/asyncio/sentinel.py 86.95% <0.00%> (-0.63%) ⬇️
tests/test_asyncio/test_search.py 98.26% <0.00%> (-0.35%) ⬇️
tests/test_asyncio/test_json.py 99.75% <0.00%> (-0.25%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dvora-h dvora-h self-requested a review December 12, 2022 08:16
@dvora-h dvora-h added the feature New feature label Dec 12, 2022
@dvora-h dvora-h changed the title Raising NotImplementedError for certain LATENCY DOCTOR commands Raising NotImplementedError for certain LATENC commands Dec 12, 2022
@dvora-h dvora-h merged commit 3a121be into redis:master Dec 12, 2022
@chayim chayim deleted the ck-latency-disables branch March 26, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for missing command LATENCY GRAPH Add support for missing command LATENCY DOCTOR
3 participants