Fix handling of CancelledError
by async client
#2607
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR is supposed to fix the issue #2593 .
The problem occurs when invoking
cancel()
on a task which was executing any redis command. Invokingcancel()
resulted in interruption of StreamReaderreadline()
method by the CancelledError. When it happened it resulted in not reading the response from StreamReader after command execution. It caused all future responses to be mixed up between commands.For example if we canceled a
ping()
command and executedexists('foo')
command afterwards StreamReader reads previously not readb"+PONG\r\n"
instead ofb":0\r\n"
which results in error when trying to parse raw data and cast it to the correct type. (This example is implemented as a working test)