Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESP 3 feature documentation #2872

Merged
merged 9 commits into from
Aug 8, 2023
Merged

RESP 3 feature documentation #2872

merged 9 commits into from
Aug 8, 2023

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 3, 2023

As part of the 5.0 release, we need to add some more documentation surrounding RESP 3. This pull requests introduces more connection examples, and fixes some broken ones. Along the way a base example for sharded pubsub and push notifications are included.

Further, in order to make it possible to catch some of our sillier documentation mistakes, such as spelling - I've included CI for spellchecking our documentation.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Aug 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -13.65% ⚠️

Comparison is base (3e50d28) 90.97% compared to head (12bf06b) 77.32%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2872       +/-   ##
===========================================
- Coverage   90.97%   77.32%   -13.65%     
===========================================
  Files         126      126               
  Lines       32178    32178               
===========================================
- Hits        29273    24881     -4392     
- Misses       2905     7297     +4392     

see 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chayim chayim merged commit b0abd55 into master Aug 8, 2023
52 of 55 checks passed
@chayim chayim deleted the ck-resp3-docsmore branch August 8, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants