Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SentinelManagedConnection.read_response() got an unexpected keyword argument 'push_request' #2894

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Aug 16, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #2893

@dvora-h dvora-h added the bug Bug label Aug 16, 2023
@dvora-h dvora-h requested a review from chayim August 16, 2023 07:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6968431) 91.27% compared to head (9c2009c) 91.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2894   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         126      126           
  Lines       32368    32368           
=======================================
+ Hits        29544    29545    +1     
+ Misses       2824     2823    -1     
Files Changed Coverage Δ
redis/sentinel.py 86.95% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentinelManagedConnection.read_response() got an unexpected keyword argument 'push_request'
3 participants