Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster determine slot command name need upper #2919

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

yangbodong22011
Copy link
Contributor

@yangbodong22011 yangbodong22011 commented Aug 29, 2023

The judgment of the name is all uppercase, for example:
https://github.com/redis/redis-py/blob/master/redis/cluster.py#L970

if command in ("EVAL", "EVALSHA"):

Repro code

#!/usr/bin/env python
#-*- coding: utf-8 -*-
from redis.cluster import RedisCluster
host = '127.0.0.1'
port = 30001
user = 'default'
pwd = ""
rc = RedisCluster(host=host, port=port, username=user, password=pwd)
print(rc.execute_command('EVAL', 'return', '0', 'hello'))

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (19b55c6) 91.29% compared to head (4bd4324) 91.34%.
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2919      +/-   ##
==========================================
+ Coverage   91.29%   91.34%   +0.05%     
==========================================
  Files         126      126              
  Lines       32391    32335      -56     
==========================================
- Hits        29570    29538      -32     
+ Misses       2821     2797      -24     
Files Changed Coverage Δ
redis/asyncio/cluster.py 91.66% <100.00%> (ø)
redis/cluster.py 92.81% <100.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yangbodong22011 yangbodong22011 force-pushed the fix-cluster-determine-slot branch from 1ccb475 to f1181b2 Compare August 29, 2023 02:45
redis/cluster.py Outdated Show resolved Hide resolved
@dvora-h dvora-h added the bug Bug label Sep 14, 2023
@yangbodong22011 yangbodong22011 force-pushed the fix-cluster-determine-slot branch from f1181b2 to c455e04 Compare September 18, 2023 08:16
The judgment of the name is all uppercase, for example:
    L970: if command in ("EVAL", "EVALSHA"):
@yangbodong22011 yangbodong22011 force-pushed the fix-cluster-determine-slot branch from c455e04 to 4bd4324 Compare September 18, 2023 08:36
@dvora-h dvora-h merged commit 086efb2 into redis:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants