-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repr of important classes with module name and recommended "< … #3001
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3001 +/- ##
===========================================
- Coverage 91.36% 77.29% -14.08%
===========================================
Files 126 126
Lines 32617 32618 +1
===========================================
- Hits 29802 25212 -4590
- Misses 2815 7406 +4591
☔ View full report in Codecov by Sentry. |
@dvora-h I think this is a 5.1 change if it's the sort of thing we want to consider. |
Sure. the changes are basically:
The reason I touched this was to make sure that any |
redis#3001) * Update repr of important classes with module name and recommended "< ... >" syntax. * update tests which examine repr * formatting
#3001) * Update repr of important classes with module name and recommended "< ... >" syntax. * update tests which examine repr * formatting
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
the
__repr__
of important classes was missing the name of themodule
, which is often important fordisambiguation. Also, the format should typically be "< ... >", according to the documentation, for consistency.
Update repr and tests accordingly
The motivation for this is to get more informative
ResourceWarning
errors, e.g. via PR #2999