Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8+isort+black with ruff #3147

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Replace flake8+isort+black with ruff #3147

merged 2 commits into from
Mar 5, 2025

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 15, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR replaces the use of flake8, isort, and black with Ruff.

More ruff rules could (should) be enabled later and the noqas taken care of.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Feb 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2f88840) 91.84% compared to head (ae415eb) 91.84%.
Report is 5 commits behind head on master.

Files Patch % Lines
redis/commands/graph/commands.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3147   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         128      128           
  Lines       33232    33272   +40     
=======================================
+ Hits        30523    30560   +37     
- Misses       2709     2712    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akx akx force-pushed the ruff branch 4 times, most recently from 47822c3 to 0fba9cd Compare May 27, 2024 17:02
@akx
Copy link
Contributor Author

akx commented May 27, 2024

rebased. cc @dvora-h @chayim

@akx
Copy link
Contributor Author

akx commented Jun 12, 2024

Rebased. Looks like @gerzse is on the move here, care to take a look?

@akx
Copy link
Contributor Author

akx commented Aug 26, 2024

Rebased. cc @gerzse.

@akx
Copy link
Contributor Author

akx commented Oct 16, 2024

Rebased. cc @vladvildanov (since you seem to be active on this repo).

@akx
Copy link
Contributor Author

akx commented Feb 25, 2025

cc @petyaslavova

@akx akx force-pushed the ruff branch 2 times, most recently from b1d6efe to 2e32405 Compare February 25, 2025 11:18
Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akx There is a conflict in one of the files. Can you please fix it?

@akx
Copy link
Contributor Author

akx commented Mar 5, 2025

@petyaslavova Conflict fixed. I also moved the configuration to pyproject.toml now that it's a thing, and made it more granular. Some of the non-free Redis modules' command modules don't adhere to usual Python naming, so they're excluded from the naming convention checks.

@petyaslavova petyaslavova merged commit 4122f7c into redis:master Mar 5, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants