Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved ClusterParser exceptions to BaseParser class #3475

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

vladvildanov
Copy link
Collaborator

@vladvildanov vladvildanov commented Jan 8, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

If RESP3 is enabled, the ClusterParser becomes immediately overridden with _RESP3Parser which leads to the fact that all additional exceptions isn't handled by cluster implementation.

ClusterParser class shouldn't exist and inherit other parsers just to extend a list of exceptions that should be associated with given error codes. Parsing errors and associate them to exception classes is a responsibility of parsers itself regardless of server topology, potentially you could get any error code as a response from server and parser should be aware of it.

@vladvildanov vladvildanov added the breakingchange API or Breaking Change label Jan 8, 2025
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why do you think it's a breaking change? I see no changes affecting public API

@vladvildanov
Copy link
Collaborator Author

vladvildanov commented Jan 15, 2025

@uglide Well, from my POV it isn't, just the fact that public class was removed makes me feel it would be wise to consider this as a breaking change

@vladvildanov vladvildanov merged commit fab31b4 into master Jan 15, 2025
33 checks passed
@vladvildanov vladvildanov deleted the vv-cluster-topology-handling branch January 15, 2025 10:00
@uglide
Copy link
Contributor

uglide commented Jan 15, 2025

Ah, I see. Good then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants