Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove decreasing of created connections count when releasing not owned by connection pool connection(fixes issue #2832). #3514

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

petyaslavova
Copy link
Collaborator

@petyaslavova petyaslavova commented Feb 18, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

  • Removing decreasing of created connections count when releasing not owned by connection pool connection(issue #2832).
  • Fixed another issue that was allowing adding connections to a pool owned by other pools.
  • Adding unit tests.

@petyaslavova petyaslavova force-pushed the ps_fix_releasing_of_connection_not_owned_by_pool branch from 5adc52b to f18988d Compare February 18, 2025 14:25
@petyaslavova petyaslavova changed the title Removing decreasing of created connections count when releasing not owned by connection pool connection(#2832). Remove decreasing of created connections count when releasing not owned by connection pool connection(#2832). Feb 18, 2025
@petyaslavova petyaslavova changed the title Remove decreasing of created connections count when releasing not owned by connection pool connection(#2832). Remove decreasing of created connections count when releasing not owned by connection pool connection(fixes issue #2832). Feb 20, 2025
@petyaslavova petyaslavova force-pushed the ps_fix_releasing_of_connection_not_owned_by_pool branch from f06e437 to ab674fd Compare February 24, 2025 13:30
@petyaslavova petyaslavova merged commit d867660 into master Feb 24, 2025
37 checks passed
@petyaslavova petyaslavova deleted the ps_fix_releasing_of_connection_not_owned_by_pool branch February 24, 2025 15:34
@petyaslavova petyaslavova added the bug Bug label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants