Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid Exception type to Except in ClusterPipeline #3516

Merged

Conversation

bssyousefi
Copy link
Contributor

First, thank you for the repo.

In a recent change in ClusterPipeline, TimeoutError has been added to reinitialize the nodes.

except (ConnectionError, TimeoutError):

However, it's a nested try-except and the upper except should also contain TimeoutError in order to respect cluster_error_retry_attempts.
retry_attempts = self.cluster_error_retry_attempts

@petyaslavova
Copy link
Collaborator

Hi @bssyousefi thank you for your contribution! We’ll review your change soon.

Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petyaslavova petyaslavova merged commit 6f752b0 into redis:master Feb 26, 2025
37 checks passed
@petyaslavova petyaslavova added breakingchange API or Breaking Change and removed breakingchange API or Breaking Change labels Feb 27, 2025
@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants