Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client_list with multiple client ids #3539

Conversation

three-kinds
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

  • The current client_list function will cause ResponseError: Invalid client ID when there are multiple client ids.
  • In the current unit test, since the length of clients is 1 and client_id = clients[:-1], client_id is an empty list, so it does not play the role of testing multiple client ids.
  • The fix is simple, please check the code.

@three-kinds three-kinds force-pushed the fix-client-list-with-multiple-client-ids branch from 35029bf to 246fee3 Compare March 4, 2025 01:25
@petyaslavova
Copy link
Collaborator

Hi @three-kinds, thank you for your contribution! Your change will be reviewed soon.

@petyaslavova petyaslavova added the bug Bug label Mar 4, 2025
Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@petyaslavova petyaslavova merged commit 805848a into redis:master Mar 4, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants