[#3618] Fix client-side cache invalidation for mixed str
and bytes
Redis keys
#3766
+46
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Problem:
Client-side caching in
redis-py
was not consistently invalidating cache entries when Redis keys were passed asbytes
while stored asstr
(or vice versa) as mentioned issue #3618. This caused stale cache values to persist in cases where keys were mixed betweenstr
andbytes
.Cause:
The
delete_by_redis_keys
method previously assumed all Redis keys werestr
and attempted deletion by encoding bytes to strings. After recent changes that normalized input to bytes, cache entries stored asstr
were no longer being matched, leading to failed deletions.Change / Fix:
delete_by_redis_keys
to temporarily support bothstr
andbytes
keys:str
, it checks the cache for both thestr
and UTF-8 encodedbytes
version.bytes
, it checks both thebytes
and UTF-8 decodedstr
version (if possible).str
/bytes
scenarios, including overlapping keys and MGET commands.Benefit:
str
keys.Testing:
bytes
forstr
keys.str
forbytes
keys.