Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding max_connections option to StrictRedis Class #665

Merged

Conversation

ohadperry
Copy link
Contributor

adding max_connections option to StrictRedis Class. This is totally needed to control this option.

@ohadperry ohadperry force-pushed the connection_pool_max_connections branch from ffd1010 to 48bb651 Compare October 13, 2015 14:31
@ohadperry
Copy link
Contributor Author

@andymccurdy Please Review. relatively small pull request . Thanks.

@andymccurdy
Copy link
Contributor

Thanks. Most people who need this option create connection pools manually. But allowing it to be specified at the client level could save a line of code in some situations.

The default value of max_connections should be None however. I'll update it after the merge.

andymccurdy added a commit that referenced this pull request Nov 2, 2015
adding max_connections option to StrictRedis Class
@andymccurdy andymccurdy merged commit e1e6805 into redis:master Nov 2, 2015
@ohadperry
Copy link
Contributor Author

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants